Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations: add comments #175

Open
EgorBu opened this issue Feb 28, 2018 · 6 comments
Open

Annotations: add comments #175

EgorBu opened this issue Feb 28, 2018 · 6 comments
Labels
feature-request New feature or request form the users v1 v1 candidates

Comments

@EgorBu
Copy link

EgorBu commented Feb 28, 2018

Hi,
It could be useful to add a comment section.
In case of tough decisions - to keep reasons why it was annotated like this.
In case of something confusing/broken - to keep it there so you don't need to switch context frequently: CAT -> issues -> CAT -> ...

@dpordomingo dpordomingo added the feature-request New feature or request form the users label Feb 28, 2018
@dpordomingo
Copy link
Contributor

When you say

CAT -> issues -> CAT

do you mean GitHub issues?
If so, how could we offer something inside CAT to keep the Worker inside CAT?

Could you provide an example of the case CAT -> issues -> CAT?

@EgorBu
Copy link
Author

EgorBu commented Feb 28, 2018

Yes, GitHub issues in this particular case.

Could you provide an example of the case CAT -> issues -> CAT?

Example: #174 - there are several suspicious diff/highlights. So I need to switch context not to lose the information that may help you to debug.

If so, how could we offer something inside CAT to keep the Worker inside CAT?

Add comments section (I think it's a good solution), so I can look through comment after I finish annotation and make issues and so on) + it will allow keeping some information for future.

@bzz bzz changed the title Add comment section Annotations: add comments Feb 28, 2018
@dpordomingo dpordomingo added the v1 v1 candidates label Mar 9, 2018
@dpordomingo
Copy link
Contributor

If I understood you, your proposal will allow the following workflow:

  • worker finds a tricky/complex/buggy/whatever filePair to annotate,
  • worker press skip with comment button -> leaves a comment attached to the filePair, and continues,
  • worker can retrieve a list of filePairs with a comment attached to proceed as needed.

@EgorBu
Copy link
Author

EgorBu commented Mar 12, 2018

You may need to add comments even to samples with a label.
Example:

Then you can go through DB and collects insights/logs/broken files/etc.

@dpordomingo
Copy link
Contributor

So instead of skip with comment it should be a kind of flag button to let the worker adding a comment into de filePair.
That way, the worker would be able to add a comment, and answer as similar/equal/different or just skip it

@EgorBu
Copy link
Author

EgorBu commented Mar 12, 2018

yes! A flag may work well in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request form the users v1 v1 candidates
Projects
None yet
Development

No branches or pull requests

2 participants