Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accessibility] Use <button> or <a role="button"> #23

Open
Malvoz opened this issue Dec 1, 2020 · 1 comment
Open

[accessibility] Use <button> or <a role="button"> #23

Malvoz opened this issue Dec 1, 2020 · 1 comment

Comments

@Malvoz
Copy link

Malvoz commented Dec 1, 2020 •
edited
Loading

<a class="gps-button"> button is announced as a "link" using a screen reader (missing role="button", see Leaflet controls).

Another option is to use <button type="button">, but requires additional styling to reset browser defaults.

Other potentially helpful resources:
@Malvoz Malvoz changed the title Use <button> or <a role="button"> [accessibility] Use <button> or <a role="button"> Jan 18, 2021
@Malvoz Malvoz changed the title [accessibility] Use <button> or <a role="button"> [accessibility] Use <button> or <a role="button"> Apr 25, 2022
@stefanocudini
Copy link
Owner

stefanocudini commented Mar 16, 2023 •
edited
Loading

@Malvoz great can you send us a little PR about this? I think is oneline around button constructor code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanocudini @Malvoz