Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integrated package managment here #4

Open
eclarke opened this issue Feb 27, 2019 · 2 comments
Open

Use integrated package managment here #4

eclarke opened this issue Feb 27, 2019 · 2 comments

Comments

@eclarke
Copy link
Member

eclarke commented Feb 27, 2019

We should rewrite the rules to use their own conda environments, as the dependencies here may conflict with other extensions.

https://snakemake.readthedocs.io/en/stable/snakefiles/deployment.html#integrated-package-management

@ressy
Copy link
Member

ressy commented Feb 27, 2019

I made a branch using "conda:" directives to isolate kaiju's environment, and it runs, but I realized that one of the basic setup steps is tricky to handle if you're doing it from scratch-- you can't easily run kaiju's makeDB.sh unless you have a good grasp of the .snakemake/conda/$hash directory structures and can get the environment created first so you can activate and use it. Alternatively you could always manually create/have a different environment containing kaiju for the initial setup, but that seems like extra work since logic is already in the extension. I'll keep thinking on this... but any other ideas, anybody?

@louiejtaylor
Copy link
Member

Will address this issue as part of sunbeam-labs/sunbeam#260. I think (as long as it's well-documented) we could actually add a rule to do the database building, if we add an option for which database the user wants to search to the config. Since the kaiju db name differs based on the reference sequence it might require a little wizardry but I think would be easier for users in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants