New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.7.0][Feature] Release Argument Pack in v1.7.0 #8385

Closed

jim19930609 opened this issue Oct 25, 2023 · 0 comments

Milestone

Contributor

jim19930609 commented Oct 25, 2023

Test all the examples w.r.t the docs: https://docs.taichi-lang.org/docs/master/argument_pack#limitations

taichi-gardener added this to Taichi Lang

github-project-automation bot moved this to Untriaged in Taichi Lang

jim19930609 added this to the v1.7.0 milestone

lin-hitonami mentioned this issue

[bug] Fix argpack with struct and vector #8403

Merged

jim19930609 pushed a commit that referenced this issue


          [bug] Fix argpack with struct and vector (#8403)

ff251e1

Issue: #8385 

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 33db838</samp>

Added support for struct arguments in kernels using `ArgPack` types and
fixed a bug with nested struct offsets. Added tests for `ArgPack` with
struct and vector types.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at 33db838</samp>

* Import `Struct` class from `taichi.lang.struct` to support struct
arguments
([link](https://github.com/taichi-dev/taichi/pull/8403/files?diff=unified&w=0#diff-ca7ad70b7884646820303ff5b04a8fd2aa7396cf4b1c7a5947a2bdf651d37a48L12-R12))
* Update `isinstance` check to include `Struct` as a possible data type
([link](https://github.com/taichi-dev/taichi/pull/8403/files?diff=unified&w=0#diff-ca7ad70b7884646820303ff5b04a8fd2aa7396cf4b1c7a5947a2bdf651d37a48L343-R343))
* Fix offset bug for nested structs by moving iterator back one position
([link](https://github.com/taichi-dev/taichi/pull/8403/files?diff=unified&w=0#diff-aea65318c1059505b73cd497b15f153d5439631cfad19f0f55061f5efa8f4272L209-R209))
* Add three tests for passing struct and vector types as `ArgPack`
elements to kernels in `test_argpack.py`
([link](https://github.com/taichi-dev/taichi/pull/8403/files?diff=unified&w=0#diff-b84304006655e02b7d4e51469ac99f189f031d811e50a32477fb6b6c19ab4fd6R27-R53))

jim19930609 closed this as completed

github-project-automation bot moved this from Untriaged to Done in Taichi Lang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment