Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase may cause commits to disappear if they have no commits pointing to it #67

Open
2 tasks
taneliang opened this issue Aug 17, 2020 · 0 comments
Open
2 tasks

Rebase may cause commits to disappear if they have no commits pointing to it #67

taneliang opened this issue Aug 17, 2020 · 0 comments
Assignees
@saphal1998
Labels
bug Something isn't working domain: SourceControl importance: 1 - must have Must be implemented for the product to be complete urgency: 2 - we can wait work type: implementation A task that primarily involves bashing code

Comments

@taneliang
Copy link
Owner

When rebasing commits in a branch, commits may disappear if they are no longer a parent of a commit with >=1 branch pointing to it.

Steps to repro

  1. Given this commit graph
    image
  2. Use Stack Attack to rebase b86cede onto faeff9f.
  3. 4628f57 should disappear, since there are no more branches pointing to it or its children.

Steps

  • Confirm that this issue is actually a thing (I didn't test it LOL)
  • Generate Stack Attack branch for new branch tips that don't have commits pointing to them
@taneliang taneliang added bug Something isn't working work type: implementation A task that primarily involves bashing code urgency: 2 - we can wait importance: 1 - must have Must be implemented for the product to be complete domain: SourceControl labels Aug 17, 2020
@saphal1998 saphal1998 self-assigned this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saphal1998 saphal1998

Labels
bug Something isn't working domain: SourceControl importance: 1 - must have Must be implemented for the product to be complete urgency: 2 - we can wait work type: implementation A task that primarily involves bashing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taneliang @saphal1998