You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bestMatchFromAppearancesWithNames method always returns the same appearance name after the first theme change. For example, when the first theme is 'Light', it returns "NSAppearanceNameAqua". After first theme change to 'Dark', it returns "NSAppearanceNameDarkAqua" correctly. However, after the second theme change to 'Light', it still returns the same value "NSAppearanceNameDarkAqua"
winit does not have this issue. It notifies ThemeChanged event repeatedly on each theme change. I tried to understand the difference between winit and tao regarding to this feature, but as far as I checked, the implementation was almost the same. They used the same macOS APIs. I could not locate the cause of this bug.
The text was updated successfully, but these errors were encountered:
Sorry but I couldn't reproduce this issue. I've tried the example from tao's window example and wry's simple example.
Both will get the event if I tried to change the appearance between light and dark.
Though my macOS version is 14.
Describe the bug
After launching a window, the first
ThemeChanged
event is emitted as expected. But the event will not be emitted after that.Steps To Reproduce
ThemeChanged
event was emited correctly in terminal outputThemeChanged
event is not emitted in terminal outputExpected behavior
ThemeChanged
event should be emitted in terminal outputScreenshots
N/A
Platform and Versions (please complete the following information):
OS: macOS 13
Rustc:
rustc 1.73.0 (cc66ad468 2023-10-03)
Would you want to assign yourself to resolve this bug?
Additional context
I did some quick triage on this issue and confirmed the followings.
effectiveAppearanceDidChangedOnMainThread
notification was sent correctly on each theme change repeatedlybestMatchFromAppearancesWithNames
method always returns the same appearance name after the first theme change. For example, when the first theme is 'Light', it returns"NSAppearanceNameAqua"
. After first theme change to 'Dark', it returns"NSAppearanceNameDarkAqua"
correctly. However, after the second theme change to 'Light', it still returns the same value"NSAppearanceNameDarkAqua"
ThemeChanged
event repeatedly on each theme change. I tried to understand the difference between winit and tao regarding to this feature, but as far as I checked, the implementation was almost the same. They used the same macOS APIs. I could not locate the cause of this bug.The text was updated successfully, but these errors were encountered: