Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to migrate to Prism? #117

Open
latortuga opened this issue Apr 16, 2024 · 3 comments
Open

Possible to migrate to Prism? #117

latortuga opened this issue Apr 16, 2024 · 3 comments

Comments

@latortuga
Copy link
Contributor

Hi there, thanks so much for ripper-tags! I use it every day and make heavy use of tags for jumping around and it's excellent!

I was reading this post today and wondered if migrating from using ripper to using Prism might be viable for this project, and whether it might speed up parsing. Thoughts?

@mislav
Copy link
Collaborator

mislav commented Apr 30, 2024

Hey, thanks for writing in. I already have a Prism migration branch going, but it's only a code spike for now. I had hoped that it will make ripper-tags end up with a simpler implementation, but it's already a lot of code. I'm not sure if it's feasible for me to complete the migration on my own and what the actual benefit of the rewrite would be, which is why I paused my work for now. Would you like me to publish the code spike in a branch?

@simi
Copy link

simi commented Dec 15, 2024

Can you share @mislav?

@mislav
Copy link
Collaborator

mislav commented Dec 17, 2024

@simi Okay it's here; I never got really far:

return PrismParser.extract(data, file) if ENV["PRISM_VISITOR"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants