Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread sleeps that were needed for old Julia versions on macOS ARM #2

Merged
merged 2 commits into from
May 8, 2024

Conversation

efaulhaber
Copy link
Member

These made the lagging issues a little better, but slowed down other architectures. For Julia 1.10, this is no longer needed.
I tested Julia 1.9, and the lagging is bad either way, so I don't see any reason to keep this. Discouraging users from using Julia 1.9 on macOS ARM is probably the better solution.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (720e728) to head (106eed4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   71.50%   71.50%           
=======================================
  Files           7        7           
  Lines         200      200           
=======================================
  Hits          143      143           
  Misses         57       57           
Flag Coverage Δ
unit 71.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented May 4, 2024

I concur with your assessment 👍

@efaulhaber efaulhaber changed the title Remove thread sleeps that were needed for old Julia verisions on macOS ARM Remove thread sleeps that were needed for old Julia versions on macOS ARM May 6, 2024
@efaulhaber efaulhaber requested a review from LasNikas May 6, 2024 15:52
@efaulhaber efaulhaber enabled auto-merge (squash) May 8, 2024 13:18
@efaulhaber efaulhaber disabled auto-merge May 8, 2024 13:21
@efaulhaber efaulhaber merged commit 17e8bd3 into main May 8, 2024
10 checks passed
@efaulhaber efaulhaber deleted the ef/remove-thread-sleep branch May 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants