Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal use warning for NHS constructors #4

Merged
merged 2 commits into from
May 13, 2024

Conversation

efaulhaber
Copy link
Member

I moved this information to trixi-framework/TrixiParticles.jl#516.

@efaulhaber efaulhaber added the documentation Improvements or additions to documentation label May 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@540505f). Click here to learn what that means.

❗ Current head 01fa331 differs from pull request most recent head b874232. Consider uploading reports for the commit b874232 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   71.50%           
=======================================
  Files           ?        7           
  Lines           ?      200           
  Branches        ?        0           
=======================================
  Hits            ?      143           
  Misses          ?       57           
  Partials        ?        0           
Flag Coverage Δ
unit 71.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber requested a review from LasNikas May 6, 2024 15:53
@efaulhaber efaulhaber enabled auto-merge (squash) May 13, 2024 08:43
@efaulhaber efaulhaber merged commit 0351767 into main May 13, 2024
8 checks passed
@efaulhaber efaulhaber deleted the ef/remove-internal-use-warning branch May 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants