Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the component is placed outside the board and connected, It should throw error #540

Open
imrishabh18 opened this issue Jan 21, 2025 · 11 comments

Comments

@imrishabh18
Copy link
Member Author

/bounty 10$

Copy link

algora-pbc bot commented Jan 21, 2025

💎 $10 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #540 with your implementation plan
  2. Submit work: Create a pull request including /claim #540 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @UTK-a-RSH Jan 23, 2025, 6:16:24 PM #594

@imrishabh18 imrishabh18 changed the title When the component is placed outside the board, It should throw error When the component is placed outside the board and connected, It should throw error Jan 21, 2025
@techmannih
Copy link
Contributor

@imrishabh18 Could you please let me know where you are encountering the error? I’m unable to see it on my end. If you could share the details, it would help me in resolving the issue.

@imrishabh18
Copy link
Member Author

@techmannih Read the description, it says to THROW an error when the components are placed outside the board and connected, and not this is THROWING an error.

@techmannih
Copy link
Contributor

@imrishabh18 Oh, yeah! Got it. I was misunderstanding. we need to do this in 3d-viewer or in this repo board component?

@UTK-a-RSH
Copy link

UTK-a-RSH commented Jan 23, 2025

/attempt #540

Copy link

algora-pbc bot commented Jan 25, 2025

@UTK-a-RSH: Reminder that in 2 days the bounty will become up for grabs, so please submit a pull request before then 🙏

@seveibar
Copy link
Contributor

Just as a note on this, the error should be a circuit json error, we don't want the rendering process to throw

@UTK-a-RSH
Copy link

@seveibar Please Explain this a bit more

@UTK-a-RSH
Copy link

Just as a note on this, the error should be a circuit json error, we don't want the rendering process to throw

Now I got what you were to trying to make me understand thanks now I have reached to the point.

Copy link

algora-pbc bot commented Jan 27, 2025

The bounty is up for grabs! Everyone is welcome to /attempt #540 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants