Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate tracking latest Nickel #6

Closed
mboes opened this issue Jan 3, 2022 · 1 comment
Closed

Automate tracking latest Nickel #6

mboes opened this issue Jan 3, 2022 · 1 comment
Assignees

Comments

@mboes
Copy link
Member

mboes commented Jan 3, 2022

Is your feature request related to a problem? Please describe.
We want Nickel documentation to be on the website, for both major releases and for current Nickel master. The Nickel documentation lives in the https://github.com/tweag/nickel repo. They happen asynchronously to updates in this repo. We can trigger a new deploy to production manually, but that's work. So we can automate this instead.

Describe the solution you'd like

  1. Make the current production deploy workflow be triggered on a nightly schedule, not just by pull requests.
  2. Replace the current submodule pointer to Nickel with flakes. Tell flakes to checkout the tip of each release branch and the tip of master. Build against whatever is the latest from each of these branches (see below regarding reproducibility).

Describe alternatives you've considered
An alternative is to record the tips of the release+master branches in the Git history at each deploy. However, if deploys happen on at least a nightly schedule, then the vast majority of the history in Git will be about that, because we don't update the website assets that often. I'd argue that the history of updates is not useful information. And we don't need the Git history to reproduce exactly a specific deploy.

cc @garbas. Original discussion: #5 (review).

Blocked on #7.

@garbas garbas self-assigned this Jan 3, 2022
@garbas
Copy link
Contributor

garbas commented Feb 10, 2022

This was now fixed as nickel is now an handled by flake and being updated (via PRs weekly) using github workflow.

Fixed by #14

@garbas garbas closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants