Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track hooks on each method #28

Closed
yangchristian opened this issue Nov 5, 2015 · 1 comment
Closed

Track hooks on each method #28

yangchristian opened this issue Nov 5, 2015 · 1 comment

Comments

@yangchristian
Copy link
Member

Right now, to completely unhook a method, we have to make a call to Collection.unhook() for each time we hooked that particular method with Collection.pre() or Collection.post(). This is because the underlying hooker module just rewraps a hooked function each time it gets hooked.

We could either:

  • Write our own hooking library/use a different one
  • Keep a hook count and have unhook() call the underlying hooker.unhook() that many times
@yangchristian
Copy link
Member Author

No more hooks (we have now have Events)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant