Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect GET request should indicate if underlying services are reachable #32

Open
kinghuang opened this issue Apr 19, 2017 · 2 comments
Assignees

Comments

@kinghuang
Copy link
Contributor

The response for GET requests unconditionally returns a 200 response with {"status": "GET ok"} right now. This should be changed to better indicate the health of the collector. For example, if Kafka isn't reachable, it could return something appropriate for that.

@kinghuang kinghuang self-assigned this Apr 19, 2017
@iinuwa
Copy link

iinuwa commented Sep 8, 2017

Hello @kinghuang! I'm interested in helping get this off the ground. What kind of checks do you think need to be implemented (besides Kafka being unreachable)?

@kinghuang
Copy link
Contributor Author

Hi, @iinuwa! Thanks for your interest! I'm thinking of implementing the HEALTHCHECK instruction in the Docker image along with returning a non 200 response. Haven't had time to think more about what else is needed. We've used this successfully as is for an in-development system, internally.

This also reminds me, I should update the README!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants