Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a discovery file for config #316

Open
thomastuts opened this issue Jan 10, 2020 · 3 comments
Open

Create a discovery file for config #316

thomastuts opened this issue Jan 10, 2020 · 3 comments

Comments

@thomastuts
Copy link
Contributor

thomastuts commented Jan 10, 2020

This will let us provide default settings for the configuration to all discovery and task files - this is needed to make sure we don't break old projects since the Bedrock@next updates rely on an Express port being present in the configuration file.

We can assign a default value for this port to avoid issues where we update old projects but don't update the project's Bedrock config.

@thomastuts thomastuts self-assigned this Jan 10, 2020
@Wolfr
Copy link
Contributor

Wolfr commented Jan 13, 2020

Is this related to the "future" idea or a hanging todo in the current idea to release 1.20+next? (Which I would release as 1.20 together)

@thomastuts
Copy link
Contributor Author

This is already done, part of the Gulp upgrade involved having to specify a specific port for our Express server serving the compiled Pug templates.

The config returned by the config discovery file is a default config merged with the config that is specified in the project's bedrock.config.js file. This means that older projects that don't have this Express config section will use the default port (which is 8000).

@Wolfr
Copy link
Contributor

Wolfr commented Jan 21, 2020

I checked out the code around having a default config 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants