Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure: Maxar API returning new fields #46

Open
scottyhq opened this issue Jan 14, 2025 · 0 comments
Open

CI Failure: Maxar API returning new fields #46

scottyhq opened this issue Jan 14, 2025 · 0 comments

Comments

@scottyhq
Copy link
Member

scottyhq commented Jan 14, 2025

https://github.com/uw-cryo/coincident/actions/runs/12681281443/job/35344701600

tests/test_search.py::test_maxar_search - assert (10, 71) == (10, 63)

Looks like maybe last week they added the following columns to api search results:

{'local_hour',
 'local_month_day',
 'local_time_of_day',
 'local_time_of_day_with_timezone',
 'timezone_offset',
 'utc_hour',
 'utc_month_day',
 'utc_time_of_day'}

Doesn't actually impact any of the current functionality... so on one hand could just remove this assertion. On the other, I like that this nightly test keeps us aware of changes to API return values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant