Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinners incorrectly increment combo color #98

Open
alchzh opened this issue Apr 19, 2021 · 2 comments
Open

Spinners incorrectly increment combo color #98

alchzh opened this issue Apr 19, 2021 · 2 comments

Comments

@alchzh
Copy link

alchzh commented Apr 19, 2021

In the osu! client, spinners don't move the combo color forward even though they're treated as their own combos. In osr2mp4 every time there's a spinner the combo color gets shifted incorrectly forward by one. This is pretty bad if there are color hax.

ComboOffset bits also shouldn't do anything if on a spinner, and the notes after the spinner should always be a new combo (the editor will correct these errors on save ppy/osu-stable-issues#733 )

@uyitroa
Copy link
Owner

uyitroa commented Apr 19, 2021

@alchzh oh never noticed that thank you

@quat1024
Copy link

quat1024 commented Nov 7, 2021

At 0:37 in this replay https://streamable.com/9kpy9d from this post https://www.reddit.com/comments/qoayac, a followpoint is visible connecting an object before the spinner to one after the spinner. The next combo also starts at 2. I haven't checked if this is just 2007 map jank though.

There's also a couple examples later on of followpoints appearing over a break from the upper-left corner, usually when a spinner was the last object before the break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants