Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentations changing the HTTP route should respect context path #51

Open
sissbruecker opened this issue Aug 23, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@sissbruecker
Copy link
Collaborator

Currently all instrumentations that modify the HTTP route, and the root span name, only use the route template. When deploying the application with a context path, for example /demo-app, then the root span name does not contain the full URL, and there is a mismatch with traces instrumented by other libraries (Servlet, Tomcat) that contain the context path.

At least the root span name should also contain the context path. For the http.route attribute it's arguable whether it should contain the context path, personally I'm leaning towards no.

@heruan heruan added the enhancement New feature or request label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants