Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Event watches picking up outdated events when installing twice into the same cluster #122

Open
TylerGillson opened this issue Aug 1, 2024 · 1 comment
Labels
bug Something isn't working stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@TylerGillson
Copy link
Member

Description

All instances of watcher, err := toolsWatch.NewRetryWatcher("1", &cache.ListWatch{WatchFunc: watchFunc}) should begin watching from the current resource version of the relevant k8s object, not 1, otherwise stale events are processed.

Reproduction steps

  1. Deploy a kind cluster
  2. Run validator install
  3. Delete plugin deployments
  4. Attempt reinstallation

Environment

validator and/or plugin versions:
kubectl version:
kind version:
etc...

Screenshots

DESCRIPTION

Logs

No response

@TylerGillson TylerGillson added the bug Something isn't working label Aug 1, 2024
Copy link

dosubot bot commented Oct 31, 2024

Hi, @TylerGillson. I'm helping the validatorctl team manage their backlog and am marking this issue as stale.

You reported a bug regarding event watchers in a Kubernetes cluster that incorrectly process outdated events when a plugin is installed multiple times. The issue arises from the watchers being initialized with a resource version of 1 instead of the current version, leading to stale event handling. You provided steps to reproduce the issue and requested additional environment details for further investigation.

Could you please let us know if this issue is still relevant to the latest version of the validatorctl repository? If it is, feel free to comment here to keep the issue open. Otherwise, you can close it yourself, or it will be automatically closed in 7 days. Thank you!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 31, 2024
@TylerGillson TylerGillson removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 31, 2024
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Development

No branches or pull requests

1 participant