Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Remove KubectlCommand function and use a k8s client instead #8

Open
ahmad-ibra opened this issue Jun 11, 2024 · 1 comment
Open
Labels
good-first-issue Good for newcomers refactoring Refactoring / tech debt

Comments

@ahmad-ibra
Copy link
Collaborator

Description

While the KubectlCommand function works, we shouldnt be directly invoking kubectl shell commands within validatorctl. Instead we should rework this so that we use a k8s client anywhere that the KubectlCommand function was invoked.

AC

  • the validatorctl no longer invokes kubectl shell commands
@TylerGillson TylerGillson changed the title Remove KubectlCommand function and use a k8s client instead 🎨 Remove KubectlCommand function and use a k8s client instead Jun 11, 2024
@TylerGillson TylerGillson added the refactoring Refactoring / tech debt label Jun 11, 2024
@TylerGillson TylerGillson added the good-first-issue Good for newcomers label Aug 9, 2024
Copy link

dosubot bot commented Nov 8, 2024

Hi, @ahmad-ibra. I'm Dosu, and I'm helping the validatorctl team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Proposal to eliminate the KubectlCommand function in favor of a Kubernetes client.
  • Aims to streamline Kubernetes interactions by removing dependency on kubectl shell commands.
  • No comments or further developments have been made on this issue.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the validatorctl repository by commenting here.
  • If there is no response, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 8, 2024
@TylerGillson TylerGillson removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers refactoring Refactoring / tech debt
Projects
None yet
Development

No branches or pull requests

2 participants