Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do not expose NetSocket in StompServerTCPConnectionImpl.java #89

Open
eternalirons opened this issue Aug 16, 2023 · 2 comments
Open

Why do not expose NetSocket in StompServerTCPConnectionImpl.java #89

eternalirons opened this issue Aug 16, 2023 · 2 comments
Labels
enhancement

Comments

@eternalirons
Copy link

As the title suggests, why do not expose NetSocket in StompServerTCPConnectionImpl.java, I would like to obtain NetSocket at server side to get localAddress and remoteAddress, but no api expose NetSocket.
@tsegismont
Copy link
Contributor

Instead of exposing a underlying socket, we could have expose the addresses like we do in HttpConnection:

https://github.com/eclipse-vertx/vert.x/blob/c252928ced746429aa00544b8c2260f30e16bc34/src/main/java/io/vertx/core/http/HttpConnection.java#L224-L246

Would you like to contribute this?

@eternalirons
Copy link
Author

Okay, I'd love to

@eternalirons eternalirons mentioned this issue Oct 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsegismont @eternalirons