Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document assets setup #210

Closed
jbmoelker opened this issue Nov 9, 2024 · 0 comments · Fixed by #217
Closed

Document assets setup #210

jbmoelker opened this issue Nov 9, 2024 · 0 comments · Fixed by #217
Assignees
@jbmoelker
Labels
documentation Improvements or additions to documentation v1 Head Start v1 private
Milestone
v1

Comments

@jbmoelker
Copy link
Member

jbmoelker commented Nov 9, 2024 •
edited
Loading

Should include:
@jbmoelker jbmoelker added the documentation Improvements or additions to documentation label Nov 9, 2024
@jbmoelker jbmoelker self-assigned this Nov 9, 2024
@jbmoelker jbmoelker mentioned this issue Nov 9, 2024
Closed
9 tasks
@jbmoelker jbmoelker added the v1 Head Start v1 private label Nov 9, 2024
@jbmoelker jbmoelker modified the milestones: v1 public, v1 Nov 9, 2024
@jbmoelker jbmoelker mentioned this issue Nov 9, 2024
Merged
3 tasks
jbmoelker added a commit that referenced this issue Nov 27, 2024
@jbmoelker
docs: assets (pubic and processed)
649bb80 
Resolves #210

Note: #209 should be merged first.
@jbmoelker jbmoelker mentioned this issue Nov 27, 2024
Merged
4 tasks
decrek added a commit that referenced this issue Jan 3, 2025
@jbmoelker @decrek
feature: custom fonts with preloading (#209)
0159b91 
# Changes

- Adds custom font import strategy using Fontsource so font files are
served from same domain and are automatically hashed for caching (when
combined with #207).
- Adds resource hints to preload the fonts for faster page rendering.

Note: based on #208 so the `<PerfHead>` could easily be extended.

# Associated issue

Resolves #87

# How to test

1. Open preview link
2. Verify a custom font is used for the page (body)
3. Open DevTools > Network and verify font files are preloaded

# Checklist

- [x] I have performed a self-review of my own code
- [x] I have made sure that my PR is easy to review (not too big,
includes comments)
- ~~I have made updated relevant documentation files (in project README,
docs/, etc)~~ created follow-up issue #210
- ~~I have added a decision log entry if the change affects the
architecture or changes a significant technology~~
- [x] I have notified a reviewer

<!-- Please strike through and check off all items that do not apply
(rather than removing them) -->

---------

Co-authored-by: Declan Rek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbmoelker jbmoelker

Labels
documentation Improvements or additions to documentation v1 Head Start v1 private
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

docs: assets (pubic and processed) voorhoede/head-start
1 participant
@jbmoelker