Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle::remove_signal #68

Open
vorner opened this issue Nov 28, 2020 · 0 comments
Open

Handle::remove_signal #68

vorner opened this issue Nov 28, 2020 · 0 comments

Comments

@vorner
Copy link
Owner

vorner commented Nov 28, 2020

The iterator::backend::Handle has add_signal, but no remove_signal. This is a bit inconsistent and it turns out people would find it useful (see #63).

By implementing it on Handle, one would get the remove_signal for all the async structures's handles and the base iterator one. It still needs exposing on each of these types separately as a method wrapper (the signals.handle().remove_signal gets „propagated“ as the Handle type is the same one for all of them, but signals.remove_signal needs to actually be added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant