Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): no params were generated when using withDefaults #12823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Feb 7, 2025

fix #12822

Copy link

github-actions bot commented Feb 7, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.3 kB
vue.global.prod.js 158 kB 57.8 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12823

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12823

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12823

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12823

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12823

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12823

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12823

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12823

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12823

vue

npm i https://pkg.pr.new/vue@12823

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12823

commit: ad7bf8f

@edison1105 edison1105 added scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. wait changes ready to merge The PR is ready to be merged. and removed wait changes labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: withDefaults Fails When Using Function Declarations With Props
2 participants