Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): prevent child component updates when style remains unchanged #12825

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Feb 8, 2025

close #12826

Copy link

github-actions bot commented Feb 8, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+78 B) 38 kB (+33 B) 34.3 kB (-3 B)
vue.global.prod.js 158 kB (+78 B) 57.9 kB (+25 B) 51.5 kB (+41 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB (+616 B) 18.4 kB (+201 B) 16.8 kB (+167 B)
createApp 54.9 kB (+619 B) 21.4 kB (+211 B) 19.5 kB (+183 B)
createSSRApp 59.2 kB (+619 B) 23.1 kB (+214 B) 21 kB (+176 B)
defineCustomElement 59.8 kB (+621 B) 23 kB (+222 B) 20.9 kB (+185 B)
overall 69 kB (+619 B) 26.6 kB (+220 B) 24.2 kB (+198 B)

Copy link

pkg-pr-new bot commented Feb 8, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12825

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12825

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12825

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12825

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12825

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12825

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12825

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12825

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12825

vue

npm i https://pkg.pr.new/vue@12825

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12825

commit: 93eafa2

@edison1105
Copy link
Member Author

/ecosystem-ci run

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 8, 2025
@vue-bot
Copy link
Contributor

vue-bot commented Feb 8, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant failure success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 marked this pull request as draft February 8, 2025 03:53
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 8, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 changed the title fix(runtime-core): prevent child component updates without changes fix(runtime-core): prevent child component updates when style remains unchanged Feb 8, 2025
@edison1105 edison1105 marked this pull request as ready for review February 8, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue onBeforeUpdate run after DOM update
2 participants