Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "process capabilities" steps provides an unreferenced "flags" parameter to "validate capabilities" #1879

Open
trflynn89 opened this issue Feb 5, 2025 · 0 comments

Comments

@trflynn89
Copy link

trflynn89 commented Feb 5, 2025

In the "process capabilities" algorithm, steps 2.2 and 5.1 provide a "flags" parameter to the "validate capabilities" algorithm:

2.2. Let required capabilities be the result of trying to validate capabilities with arguments required capabilities and flag.
5.1. Let validated capabilities be the result of trying to validate capabilities with arguments first match capabilities and flags.

(Note there's also a typo in step 2.2., it says "flag" instead of "flags").

However, the "validate capabilities" algorithm does not mention any flags parameter in its header, nor is it referenced in any of its steps:

When required to validate capabilities with argument capabilities: 

On the other hand, the "matching capabilities" algorithm does need a flags parameter, but "process capabilities" does not provide this parameter in step 8.1:

8.1. Let matched capabilities be the result of trying to match capabilities with capabilities as an argument. 
When matching capabilities given JSON Object capabilities, and a session configuration flags flags, an endpoint node must take the following steps:

Further, the use of "flags" within "matching capabilities" seems strangely written. It is used to conditionally set the "strictFileInteractability" item in step 2:

2. If flags contains "http", add the following entries to matched capabilities:

   "strictFileInteractability"
   Boolean initially set to false, indicating that interactabilty checks will be applied to <input type=file>. 

(There's another typo here, should be "interactability checks").

However, this item is already set in step 1. Should the item in step 1 have been removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant