Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI integration test step is rebuilding all container images #2147

Closed
bboreham opened this issue Jul 2, 2018 · 0 comments · May be fixed by #2149
Closed

CI integration test step is rebuilding all container images #2147

bboreham opened this issue Jul 2, 2018 · 0 comments · May be fixed by #2149
Labels
chore refinement/improvement of end user functionality; making things work better stale Bulk closing old, stale issues

Comments

@bboreham
Copy link

bboreham commented Jul 2, 2018

Currently the integration test step in CI is taking minutes to build the build container and various other images, despite having downloaded the ones built in the build step.

I spent some time trying to untangle this. Nearly all of the integration tests (Notifications is an exception) don't go anywhere near the image - they are running Go unit tests with a real database/nats instead of a mock one. However the images are declared as dependencies of these tests in the Makefile.

The build container is needed to run some code-generation steps for protos.

Once the protos have been generated, they are now newer than the downloaded images, so the images get rebuilt.

I can see three ways to go:

  • re-do all integration tests to use the images
  • admit that we are rebuilding images and stop downloading them during CI
  • fix the dependencies and special-case the notifications test so it doesn't rebuild
@bboreham bboreham added the chore refinement/improvement of end user functionality; making things work better label Jul 2, 2018
@ozamosi ozamosi added the stale Bulk closing old, stale issues label Nov 4, 2021
@ozamosi ozamosi closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore refinement/improvement of end user functionality; making things work better stale Bulk closing old, stale issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants