You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the integration test step in CI is taking minutes to build the build container and various other images, despite having downloaded the ones built in the build step.
I spent some time trying to untangle this. Nearly all of the integration tests (Notifications is an exception) don't go anywhere near the image - they are running Go unit tests with a real database/nats instead of a mock one. However the images are declared as dependencies of these tests in the Makefile.
The build container is needed to run some code-generation steps for protos.
Once the protos have been generated, they are now newer than the downloaded images, so the images get rebuilt.
I can see three ways to go:
re-do all integration tests to use the images
admit that we are rebuilding images and stop downloading them during CI
fix the dependencies and special-case the notifications test so it doesn't rebuild
The text was updated successfully, but these errors were encountered:
bboreham
added
the
chore
refinement/improvement of end user functionality; making things work better
label
Jul 2, 2018
Currently the
integration
test step in CI is taking minutes to build the build container and various other images, despite having downloaded the ones built in thebuild
step.I spent some time trying to untangle this. Nearly all of the integration tests (Notifications is an exception) don't go anywhere near the image - they are running Go unit tests with a real database/nats instead of a mock one. However the images are declared as dependencies of these tests in the Makefile.
The build container is needed to run some code-generation steps for protos.
Once the protos have been generated, they are now newer than the downloaded images, so the images get rebuilt.
I can see three ways to go:
The text was updated successfully, but these errors were encountered: