Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Imports failing after upgrading from v1.2.0-beta.0 to v1.2.0+ #9135

Open
PointSingularity opened this issue Jan 28, 2025 · 1 comment
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.

Comments

@PointSingularity
Copy link

System Info

System:
OS: macOS 15.1.1
CPU: (12) arm64 Apple M2 Pro
Memory: 342.13 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.13.0 - ~/.proto/shims/node
Yarn: 4.1.1 - ~/.proto/shims/yarn
Browsers:
Chrome: 132.0.6834.111
Edge: 132.0.2957.127
Safari: 18.1.1

Details

After updating to version 1.2.0, it seems Rspack can not find some packages in node_modules.

I linked a reproduction, and it is a bit janky with the copy of folders, but wanted to reproduce as close as possible to the real prod situation I have.

Reproduce link

https://github.com/PointSingularity/rspack-repro

Reproduce Steps

  • Run yarn
  • Copy @mycompany folder to node_modules
  • Run yarn build

You should get no errors.

Then update rspack to a newer version:

  • Run yarn up @rspack/cli @rspack/core
  • Optional: Copy @mycompany folder to node_modules (only if it was removed with the new install)
  • Run yarn build

There are errors.

If you use the commented import in packages/app/src/index.js instead of the top one, then it works partially, but it still breaks.

@PointSingularity PointSingularity added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jan 28, 2025
@PointSingularity PointSingularity changed the title [Bug]: Import failing after upgrading from v1.2.0-beta.0 to v1.2.0+ [Bug]: Imports failing after upgrading from v1.2.0-beta.0 to v1.2.0+ Jan 28, 2025
@damiangolojuch
Copy link

damiangolojuch commented Jan 31, 2025

Same, last working version is 1.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.
Projects
None yet
Development

No branches or pull requests

2 participants