New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags should be optional. #107

Open

gdborton opened this issue Jan 28, 2025 · 1 comment

gdborton commented Jan 28, 2025

What version of this package are you using?
Latest

What operating system, Node.js, and npm version?
N/A

What happened?
I got an extended message that didn't contain flags, and the ut_pex module failed to add them.

What did you expect to happen?
It shouldn't fail if flags are omitted.

Are you willing to submit a pull request to fix this bug?
Yes, but I'm not 100% sure yet how to fix.

BEP 11 states that flags are optional:
https://bittorrent.org/beps/bep_0011.html

Author

gdborton commented Jan 28, 2025

Oh... addPeer allows for undefined for the flags value... pretty sure this will be easy... PR incoming

gdborton mentioned this issue

BREAKING CHANGE: Allow for added.f and added6.f to be optional #108

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment