-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all wireframe directories to $config->paths #22
Comments
Hey @ivangretsky, After going back and forth on this for numerous times, I ended up adding a new configuration setting for this:
The point is that it's now easy to decide on a site-by-site basis which paths should be stored in ProcessWire's global $config->paths object, but the default is still that only "partials" is available. While I do believe that it might be nice to have other paths available as well (by default), at the same time I'm a little hesitant since this is indeed a global config object. Basically I'd like to avoid "polluting" any global space until there's a solid reason for that, i.e. it is a requirement to get something done :) Again it may make sense on a per-site basis to open up more paths this way, so I do think that this new config setting makes sense. Additionally it's now very easy to later add more paths to global config, if deemed necessary. -- Just for context: Partials is available for both historical reasons (initially recommended approach was to use this path to include partials), so removing it is not an option (without BC break), and because static Factory class makes use of it internally. Other classes are not required by Wireframe to be publicly accessible, and they have never been publicly available, so there's no similar issue. Anyway, let me know if you think this should still be improved. I'm open for suggestions :) |
This looks great!
|
|
Good day!
I suggest we add all Wireframe paths to
$config->paths
for easier access. Now I see only$config->paths->partials
there.The text was updated successfully, but these errors were encountered: