feat(checkbox/radioButton): ensure minimum 48x48 hit target for better accessibility #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…r accessibility Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: [email protected] <[email protected]>
… functions Co-Authored-By: [email protected] <[email protected]>
nitzanyiz
reviewed
Feb 19, 2025
src/components/radioButton/index.tsx
Outdated
Comment on lines
290
to
291
| {iconOnRight ? this.renderLabel() : this.renderIcon()} | ||
| {iconOnRight ? this.renderIcon() : this.renderLabel()} |
There was a problem hiding this comment.
Don't make this change with the iconOnRight prop. Lets leave it as it was.
nitzanyiz
reviewed
Feb 19, 2025
src/components/radioButton/index.tsx
Outdated
| render() { | ||
| const {onPress, onValueChange, containerStyle, contentOnLeft, ...others} = this.props; | ||
| const {onPress, onValueChange, containerStyle, contentOnLeft, iconOnRight, ...others} = this.props; |
There was a problem hiding this comment.
remove this change as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves Checkbox and RadioButton components accessibility by ensuring a minimum hit target size of 48x48 pixels using hitSlop, without affecting visual appearance.
Link to Devin run: https://app.devin.ai/sessions/fc2cb153860345108b58985f0b922733