Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): ensure minimum 48x48 hit target for better accessibility #3520

Closed

Conversation

devin-ai-integration[bot]
Copy link

@devin-ai-integration devin-ai-integration bot commented Feb 19, 2025

Button Component Accessibility Improvements

This PR improves the accessibility of the Button component by ensuring a minimum hit target size of 48x48 pixels, following WCAG guidelines.

Changes

  • Added getAccessibleHitSlop function to calculate necessary padding based on container size
  • Added hitSlop to TouchableOpacity component
  • Maintained existing visual appearance while improving touch target size
  • Properly handles different button sizes and styles

Testing

The changes have been verified through CI checks and maintain existing functionality.

Link to Devin run: https://app.devin.ai/sessions/fc2cb153860345108b58985f0b922733

Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@nitzanyiz
Copy link
Collaborator

This pr is for the button accessibility hitslop. please fix the title

@devin-ai-integration devin-ai-integration bot changed the title feat(avatar): ensure minimum 48x48 hit target for better accessibility feat(button): ensure minimum 48x48 hit target for better accessibility Feb 19, 2025
@devin-ai-integration devin-ai-integration bot deleted the devin/1739971959-button-hit-target branch February 19, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant