Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES Modules #35

Open
AlexanderMelde opened this issue Oct 5, 2023 · 0 comments
Open

Support ES Modules #35

AlexanderMelde opened this issue Oct 5, 2023 · 0 comments

Comments

@AlexanderMelde
Copy link

AlexanderMelde commented Oct 5, 2023

Hello Javier,
when importing your script into typescript Angular projects, the following warning appears:

Warning: [file] depends on 'js-angusj-clipper/web'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

I have reviewed the source code here and it seems like this project is not yet a ES Module.
For any modern typescript project, it would be helpful if you could provide a ES6 Module.
You can read more about the benefits of ESM here and here.

Let me know if I can help during the implementation of this.

Best,
Alexander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant