-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move demo app to separate repo #272
Comments
@sophiedeziel how do you feel about this? |
I think we should move it out only when we have at least some dev tooling. My reasoning is that this project is a voluntary one. Friction and pain have a far more negative impact than the cleanliness of this repo. Maintaining the demo in a monorepo is not as painful as maintaining all the examples. Since we're directly developing from the demo, it is almost always in an ideal state. |
Ok I have to agree with what you say. I guess what I hadn't mentioned is my reasoning for the split. The demo has 2 roles, one being a showcase for the lib and other being a deployed application in and of itself. Lately, with the work on the alpha it felt like I was polluting the main repo whenever I was making changes to the demo. And it it would help me with getting a sense of overview in a more focused repo. But yeah we need to have some host app to dev the lib with, without needing a complicated setup. If the demo is in a separate repo, we can still use it for dev purposes but it will definitely require a more effort to setup. That setup is the thing that needs to be validated imo. And not just by one person. How about we let this marinate for a while 😉 |
I've felt the same! We've identified a need for something we can absolutely fill with tons of devs concerns, flexibility and setup. And a need for keeping the demo what it is: a demo. What if we extract the demo code in a new repo without removing it from here? Then, rename it in this repo as |
post scriptum: the |
Separating the demo app from the lib will enable more focus but it has a cost in terms of dev experience. Basically developing won't be as easy as the current single cmd
npm run dev
.The text was updated successfully, but these errors were encountered: