Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: failing to patch modules for which two or more JARs have been specified #41

Open
siordache opened this issue Oct 23, 2018 · 0 comments
Open

Windows: failing to patch modules for which two or more JARs have been specified #41

siordache opened this issue Oct 23, 2018 · 0 comments

Comments

@siordache
Copy link

Oracle's Tools Reference incorrectly shows the : character as separator for the files that patch a given module:

--patch-module module=file(:file)*

The actual separator, as specified in JEP 261 is the host platform's path-separator character:

--patch-module <module>=<file>(<pathsep><file>)*

A look at the source code reveals that javac handles this option in accordance with JEP 261.

On Windows, due to the above mentioned inaccuracy, the plugin fails to patch modules for which two or more JARs have been specified.

I will provide a PR shortly.
siordache added a commit to siordache-forks/chainsaw that referenced this issue Oct 23, 2018
@siordache
fix issue zyxist#41
6660819 
use the host platform's path-separator character to delimit the files passed to the --patch-module option
Kneelawk added a commit to Kneelawk/chainsaw that referenced this issue May 18, 2019
@Kneelawk
Merge pull request #1 from siordache-forks/issue#41
d6149d2 
fix issue zyxist#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siordache