Various refactors and fixes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixes can be separated into 2: - compilation errors (most of them were because the old `Account::new` became `Account::from_parts` and the addition of `OutputNote::Partial` which needed to be handled in some pattern matchings. - start storing the partial output notes (currently being discarded), this also came with small refactors.
test will fail on retry anyways since the genesis account stays is the same every time.
mFragaBA
force-pushed
the
mFragaBA-next-0.4
branch
2 times, most recently
from
41aa14d to
3680cef
Compare
mFragaBA
force-pushed
the
mFragaBA-next-0.4
branch
from
3680cef to
cd11167
Compare
…/miden-client into mFragaBA-next-0.4
igamigo
force-pushed
the
igamigo-refactors
branch
from
d0122c6 to
7929130
Compare
mFragaBA
reviewed
Jun 13, 2024
mFragaBA
force-pushed
the
mFragaBA-next-0.4
branch
2 times, most recently
from
215f26a to
e4a2565
Compare
mFragaBA
reviewed
Jun 18, 2024
src/client/chain_data.rs
Outdated
There was a problem hiding this comment.
I think this was deleted in a previous commit. Do we need it again?
There was a problem hiding this comment.
Ah yes, I had removed it in the other PR and accidentally re-added it here on the merge. Removed again!
mFragaBA
approved these changes
Jun 18, 2024
bobbinth
pushed a commit
that referenced
this pull request
Jul 5, 2024
* feat: point to miden base's next and fix errors The fixes can be separated into 2: - compilation errors (most of them were because the old `Account::new` became `Account::from_parts` and the addition of `OutputNote::Partial` which needed to be handled in some pattern matchings. - start storing the partial output notes (currently being discarded), this also came with small refactors. * fix: filter out partial notes * fix: only store in scripts table if output note record has a script * fix: add new storage type to node config file from #365 * Update the `TransactionAuthenticator` imports * Remove duplicate `get_falcon_signature` * fix: update note script root hashes * Use `&mut rng` for note creation in transactions * Fix usage of new `InputNote` * fix: fix after rebase * cargo: point to node's next branch * Change node ref * test: avoid reruns on genesis cli tests test will fail on retry anyways since the genesis account stays is the same every time. * add looser sleep times to ensure blocks are included * test: add helper to wait until notes get committed/consumed * deps: point to miden-node's next branch and fix compilation errors * Test transaction ordering * make: remove dependency for node to avoid duplication on CI * Rollback node branch * fix: fix breaking change from base * fix: update swap note script root * Various refactors and simplifications * Lints * Lints * Re-add parameter * Reviews * Fixes * Test fix * Remove file again --------- Co-authored-by: Martin Fraga <[email protected]> Co-authored-by: tomyrd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these were done as part of #361 which was closed. I think we still want to keep them.