Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modernize styling of content picker #359

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Feb 19, 2025

Description of the Change

For a while now the sortable list of selected posts of the content picker has felt a bit out of place in the WP admin. This PR aims to improve it visually.

Before:

CleanShot.2025-02-19.at.10.31.19.mp4

After:

CleanShot.2025-02-19.at.11.54.28.mp4

Copy link

github-actions bot commented Feb 19, 2025

Size Change: +4.16 kB (+6.51%) 🔍

Total Size: 68.1 kB

Filename Size Change
dist/index.js 68.1 kB +4.16 kB (+6.51%) 🔍

compressed-size-action

Copy link

cypress bot commented Feb 19, 2025

10up Block Components    Run #957

Run Properties:  status check failed Failed #957  •  git commit 898a7f9fca: fix type
Project 10up Block Components
Branch Review feature/modernize-styling-of-content-picker
Run status status check failed Failed #957
Run duration 06m 48s
Commit git commit 898a7f9fca: fix type
Committer Fabian Kägy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 32
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Tests for review

Failed  ColorSettings.spec.js • 5 failed tests

View Output

Test Artifacts
ColorSettings > Allows the user to pick the block and displays it Test Replay Screenshots
ColorSettings > Allows the user to use a custom color and displays it Test Replay Screenshots
ColorSettings > Allows the user to clear the color Test Replay Screenshots
ColorSettings > Allows the user to add custom label and help text Test Replay Screenshots
ColorSettings > Allows the user to pick from predefined colors Test Replay Screenshots
Failed  Counter.spec.js • 6 failed tests

View Output

Test Artifacts
Counter > Allows the user to pick the block and displays it Test Replay Screenshots
Counter > Has the counter component in the block Test Replay Screenshots
Counter > Has the correct starting value Test Replay Screenshots
Counter > Updates the count appropriately Test Replay Screenshots
Counter > Updates to the approaching limit state appropriately Test Replay Screenshots
Counter > Updates to the is over limit state appropriately Test Replay Screenshots
Failed  IconPicker.spec.js • 1 failed test

View Output

Test Artifacts
IconPicker > allows the user to use the post picker to change an icon and displays it Test Replay Screenshots
Failed  Link.spec.js • 1 failed test

View Output

Test Artifacts
Link > allows the editor to pick a link directly inline Test Replay Screenshots
Failed  PostFeaturedImage.spec.js • 3 failed tests

View Output

Test Artifacts
PostFeaturedImage > Allows the user to pick the block and displays it Test Replay Screenshots
PostFeaturedImage > Allows the user to pick an image from the media library and displays it inline Test Replay Screenshots
PostFeaturedImage > Syncs with the post featured image Test Replay Screenshots

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! Left a few minor comments around font sizes mostly but nothing blocking!

@s3rgiosan
Copy link
Member

LGTM! This looks awesome @fabiankaegy 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants