Remove shared assets #277
Open
Remove shared assets #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiankaegy Should we remove the following? plugin
standard theme
|
fabiankaegy
approved these changes
Feb 19, 2025
|
@fabiankaegy did you see my previous comment? #277 (comment) |
|
@claytoncollie sorry missed that. Only looked at the code view... I'd be happy with that 👍 |
|
@fabiankaegy ready for a re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes the shared assets (CSS and JS) from the plugin and the standard theme.
It also removes the PHP associated with enqueuing the assets.
Closes #276
Changelog Entry
Credits
Props @claytoncollie
Checklist: