Add const support for integer types #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marton6
reviewed
Dec 23, 2024
This was commented while debugging and was missed to be uncommented afterwards.
edif2008
force-pushed
the
eddy/int-const-support
branch
from
426db2a to
d6bbec8
Compare
hculea
reviewed
Jan 20, 2025
hculea
reviewed
Jan 20, 2025
hculea
reviewed
Jan 20, 2025
edif2008
force-pushed
the
eddy/int-const-support
branch
from
0a8efb0 to
15a6181
Compare
darrell-roberts
approved these changes
Jan 21, 2025
Closed
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the functionality to parse Rust integer constants and generate them into the following languages:
The foundational pieces can easily be extended to other constant types (e.g. Boolean, Float and String). However, additional guidance and support might be needed to ensure it works as expected for the other types as well.
This is heavily inspired from #57. It was adapted to the latest version from
mainand added the code generation snippets for Go, Typescript and Python.Relates: #44