-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tailscale healthcheck #44
Conversation
Updated tailscale healthcheck to be more robust
Hello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
For reference: https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port / This functionality is available in Tailscale 1.78 and later. |
Thanks for the PR. Please check comments/suggestions and subsequent update the other services, thanks! |
Updated tailscale healthcheck port to reduce the chance of it clashing with another service
This is deprecated: ```TS_HEALTHCHECK_ADDR_PORT``` From v1.78, use instead: ```TS_ENABLE_HEALTH_CHECK``` ```TS_LOCAL_ADDR_PORT``` See here for reference: https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port
This is recently deprecated: From v1.78, use instead: As the services in this repo are using the 'latest' tailscale image tag, it's best to make use the new method. See here for reference: Thanks |
Looks good! If you could update the rest of the services, please 🚀 |
Improved the Tailscale heathcheck for every service in the repo.
All done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamsthws 🚀
Thank you very much @adamsthws!! |
Improvment To Tailscale Healthcheck
Summary
This change provides a more robust and accurate way to monitor the health of the tailscale service, improving the reliability and observability of the deployment.
This pull request updates the healthcheck configuration to use:
instead of:
Reasons for the Change
Checking 'tailscale status' only verifies that the Tailscale daemon is running, not that the service is functioning correctly or that the service is reachable or working as expected.
The new healthcheck ensures that the application or service behind Tailscale is reachable by probing a specific health endpoint (e.g., /healthz), providing a more meaningful validation of the system's operational state.
The new method makes use of the HTTP health endpoint that is explicitly designed to signal service health. This endpoint returns 200 OK if the node has at least one Tailnet IP address assigned, otherwise, it returns 503. This provides a direct indication of the node's connectivity to the Tailnet.