2i2c-aws-us, cosmicds: cleanup not needed trick for repo2docker logs #3807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed that this isn't needed, practically checking that I get logs at
/srv/repo/.jupyter-server-log.txt
even when we leavesingleuser.cmd
set to jupyterhub-singleuser, which overrides the docker image'sCMD
(but notENTRYPOINT
).repo2docker sets ENTRYPOINT (k8s command) and CMD (k8s args, and singleuser.cmd mapping to KubeSpawner.cmd) like this, as seen from
docker inspect quay.io/nmearl/hubble-user-image:294205fdd286
:With this, #3805, and #3797, we no longer set
cmd
explicitly for any community, and rely systematically on the z2jh defaults of specifyingsingleuser.cmd
. In practice, imagesENTRYPOINT
are systematically untouched, and imagesCMD
are systematically replaced withjupyterhub-singleuser
.