-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PureSoA: Disable AoS Access #3290
Merged
atmyers
merged 17 commits into
AMReX-Codes:development
from
AlexanderSinn:more_soa_fixes
Sep 22, 2023
Merged
PureSoA: Disable AoS Access #3290
atmyers
merged 17 commits into
AMReX-Codes:development
from
AlexanderSinn:more_soa_fixes
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ax3l
reviewed
May 9, 2023
ax3l
force-pushed
the
more_soa_fixes
branch
2 times, most recently
from
May 9, 2023 00:16
abf12ab
to
9e9dbb8
Compare
8 tasks
atmyers
pushed a commit
that referenced
this pull request
May 15, 2023
## Summary More updates to `ParticleTile` and simplifications for pure SoA support. ## Additional background Isolated from #3290 and author credited to @AlexanderSinn. ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate Co-authored-by: Alexander Sinn <[email protected]>
atmyers
approved these changes
May 24, 2023
ax3l
approved these changes
May 25, 2023
For the errors in
I started porting those in #3280 |
ax3l
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using a PureSoA particle container, trying to access the AoS components will now result in a compile-time error.
Previously it still compiled, and I suspect it even allocated memory for AoS.
New error message:
Using this I found more places that needed to be updated to account for PureSoA.
PureSoA still has the following issues:
DenseBins.H
) as they require a particle pointer.ParticleTileData
struct that is used to access SoA data can be very large, over 300 bytes in some cases. I recommend changing the array-of-pointers to a full 2D array. This way ParticleTileData could be as small as 24 bytes (real pointer, int pointer, stride).Additional background
Follow-up to #2878.
Checklist
The proposed changes: