Refactor workload tracking and message generation #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidpixel
requested changes
Jan 31, 2025
| } | ||
|
|
||
|
|
||
| void WorkloadMetadataEmitterVisitor::emitMetadata(Device & layerDevice, uint32_t pid, uint32_t major, uint32_t minor, uint32_t patch, std::string name) |
There was a problem hiding this comment.
Just "device" rather than "layerDevice" given the next two functions just use "device"? Or use "layerDevice" there?
| @@ -122,17 +85,84 @@ class LCSWorkload | |||
| */ | |||
| uint64_t tagID; | |||
There was a problem hiding this comment.
Style everywhere else is members declared after methods.
|
|
||
| private: | ||
| /** | ||
| * @brief The application debug label. | ||
| * | ||
| * The label is stored in a shared point to avoid copying the actual string when it is shared between subcommandbuffers |
bengaineyarm
force-pushed
the
protobufs
branch
from
4d070a8 to
b939438
Compare
…amic dispatch. Switch to a variant based instruction, rather than using dynamic dispatch + enum as this is more type safe. Remove the duplicated object in command_buffer.
No need to carry around the extra state uncessarily. This also makes clear from the type, rather than from the magic tagID value that the renderpass is a continuation. This makes refactoring to separate out the the workload as a data object from operations on that data safer since they will not need to propogate this magic knowledge forward.
…kloadMetadataEmitterVisitor. This centralizes the construction of metadata payloads into one place, decoupling the metadata format from the layer driver handler functions.
This is now moved into the centralized serializer for the layer driver in workload_metadata_builder and fully decouples the state tracker from the timeline layer's data serialization
bengaineyarm
force-pushed
the
protobufs
branch
from
b939438 to
7a846c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks some of the state tracking, decoupling it from the timeline-layer specific data serialization.
This shouldn't change the serialized JSON data, but it is preparation work for moving to protobufs.