Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Brayo author merges #10

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Jul 12, 2024

#9 Doesn't exactly merge by email but it fixes my issue. Could do the merge by email later if it's necessary.


🚀 This description was created by Ellipsis for commit f0e5415

Summary:

Added a new author merge rule for 'Brayo' in src/contributor_stats/main.py to attribute contributions from alias 'brayo' correctly.

Key points:

  • Added a new author merge rule for 'Brayo' in src/contributor_stats/main.py.
  • Ensures contributions from alias 'brayo' are attributed to 'Brayo'.
  • Modified get_authorInfos function to include the new rule.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f0e5415 in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/contributor_stats/main.py:70
  • Draft comment:
    Please ensure that 'brayo' is indeed an alias of 'Brayo' and not a separate contributor. This check is crucial to maintain accurate author attribution.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new author merge for 'Brayo' with the alias 'brayo'. This is a straightforward addition to the existing list of author merges. The change is minimal and seems correct as it follows the existing pattern of mapping aliases to a canonical name. However, it's important to ensure that the alias 'brayo' is indeed an alias of 'Brayo' and not a separate contributor. This would typically require checking the commit history or other metadata in the repository to confirm that 'brayo' should be merged under 'Brayo'.

Workflow ID: wflow_vQ4Op2je5ALY1Wpc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo
Copy link
Member Author

0xbrayo commented Jul 16, 2024

@ErikBjare could you please review and merge this?

@ErikBjare ErikBjare merged commit 84b0cd1 into ActivityWatch:master Jul 16, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants