Cheetahs - June V #100

junemv · 2022-11-23T08:43:37Z

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Yes, I had some issues with formatting and with the SVG metadata
Why is it important to consider and use semantic HTML?	it improves readability
How did you decide to structure your CSS?	Colors > IDs > Classes > All Other Parameters
What was the most challenging piece of this assignment?	Working with grid and getting content to line up the way I wanted to was the toughest part
Describe one area that you gained more clarity on when completing this assignment	I feel like using grid and flexbox is much less intimidating!
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	https://junemv.github.io/personal-portfolio-site/index.html

kendallatada

Hi June! Your project has been scored as green. You can find my comments in your code. Great job! Your site looks super professional. Also, loved seeing your artwork! 😊

kendallatada · 2022-12-14T21:31:41Z

pages/index.html

+      <!-- header social links -->
+      <ul class="social-btn-arrangement">
+        <li class="header-social-btn">
+          <a href="https://github.com/junemv" target="_blank"><svg fill="#000000" xmlns="http://www.w3.org/2000/svg"  viewBox="0 0 24 24"><path d="M 12 2 C 6.476563 2 2 6.476563 2 12 C 2 17.523438 6.476563 22 12 22 C 17.523438 22 22 17.523438 22 12 C 22 6.476563 17.523438 2 12 2 Z M 12 4 C 16.410156 4 20 7.589844 20 12 C 20 12.46875 19.953125 12.929688 19.875 13.375 C 19.628906 13.320313 19.265625 13.253906 18.84375 13.25 C 18.53125 13.246094 18.140625 13.296875 17.8125 13.34375 C 17.925781 12.996094 18 12.613281 18 12.21875 C 18 11.257813 17.53125 10.363281 16.78125 9.625 C 16.988281 8.855469 17.191406 7.535156 16.65625 7 C 15.074219 7 14.199219 8.128906 14.15625 8.1875 C 13.667969 8.070313 13.164063 8 12.625 8 C 11.933594 8 11.273438 8.125 10.65625 8.3125 L 10.84375 8.15625 C 10.84375 8.15625 9.964844 6.9375 8.34375 6.9375 C 7.777344 7.507813 8.035156 8.953125 8.25 9.6875 C 7.484375 10.417969 7 11.28125 7 12.21875 C 7 12.546875 7.078125 12.859375 7.15625 13.15625 C 6.878906 13.125 5.878906 13.03125 5.46875 13.03125 C 5.105469 13.03125 4.542969 13.117188 4.09375 13.21875 C 4.03125 12.820313 4 12.414063 4 12 C 4 7.589844 7.589844 4 12 4 Z M 5.46875 13.28125 C 5.863281 13.28125 7.0625 13.421875 7.21875 13.4375 C 7.238281 13.492188 7.257813 13.542969 7.28125 13.59375 C 6.851563 13.554688 6.019531 13.496094 5.46875 13.5625 C 5.101563 13.605469 4.632813 13.738281 4.21875 13.84375 C 4.1875 13.71875 4.148438 13.597656 4.125 13.46875 C 4.5625 13.375 5.136719 13.28125 5.46875 13.28125 Z M 18.84375 13.5 C 19.242188 13.503906 19.605469 13.570313 19.84375 13.625 C 19.832031 13.691406 19.796875 13.746094 19.78125 13.8125 C 19.527344 13.753906 19.109375 13.667969 18.625 13.65625 C 18.390625 13.652344 18.015625 13.664063 17.6875 13.6875 C 17.703125 13.65625 17.707031 13.625 17.71875 13.59375 C 18.058594 13.546875 18.492188 13.496094 18.84375 13.5 Z M 6.09375 13.78125 C 6.65625 13.785156 7.183594 13.824219 7.40625 13.84375 C 7.929688 14.820313 8.988281 15.542969 10.625 15.84375 C 10.222656 16.066406 9.863281 16.378906 9.59375 16.75 C 9.359375 16.769531 9.113281 16.78125 8.875 16.78125 C 8.179688 16.78125 7.746094 16.160156 7.375 15.625 C 7 15.089844 6.539063 15.03125 6.28125 15 C 6.019531 14.96875 5.929688 15.117188 6.0625 15.21875 C 6.824219 15.804688 7.097656 16.5 7.40625 17.125 C 7.683594 17.6875 8.265625 18 8.90625 18 L 9.03125 18 C 9.011719 18.109375 9 18.210938 9 18.3125 L 9 19.40625 C 6.691406 18.472656 4.933594 16.5 4.28125 14.0625 C 4.691406 13.960938 5.152344 13.855469 5.5 13.8125 C 5.660156 13.792969 5.863281 13.777344 6.09375 13.78125 Z M 18.625 13.90625 C 19.074219 13.917969 19.472656 14.003906 19.71875 14.0625 C 19.167969 16.132813 17.808594 17.855469 16 18.90625 L 16 18.3125 C 16 17.460938 15.328125 16.367188 14.375 15.84375 C 15.957031 15.554688 16.988281 14.863281 17.53125 13.9375 C 17.910156 13.910156 18.355469 13.898438 18.625 13.90625 Z M 12.5 18 C 12.773438 18 13 18.226563 13 18.5 L 13 19.9375 C 12.671875 19.980469 12.339844 20 12 20 L 12 18.5 C 12 18.226563 12.226563 18 12.5 18 Z M 10.5 19 C 10.773438 19 11 19.226563 11 19.5 L 11 19.9375 C 10.664063 19.894531 10.324219 19.832031 10 19.75 L 10 19.5 C 10 19.226563 10.226563 19 10.5 19 Z M 14.5 19 C 14.742188 19 14.953125 19.175781 15 19.40625 C 14.675781 19.539063 14.34375 19.660156 14 19.75 L 14 19.5 C 14 19.226563 14.226563 19 14.5 19 Z"/></svg></a>


Super cool that you used SVGs! 👏🏾

kendallatada · 2022-12-14T21:35:38Z

pages/index.html

+        <img src="../assets/computer-stockimg.png" alt="Computer Stock Image" ID="computer-img">
+      </section>
+    </main>
+    <footer class="footer">


Try to avoid creating unnecessary classes. I would recommend directly selecting the footer element by tag name.

kendallatada · 2022-12-14T21:58:51Z

pages/about.html

+          <img src="../assets/profile-photo.jpg" alt="Profile Photo" class="profile-photo"> 
+        </div>
+        <section class="profile-description">
+          <h3 class="paragraph-header">


Make sure you don't skip levels when using <h1>-<h6> tags for headings! Browsers use heading tags to construct a table of contents, so the different numbers on heading tags should be treated as different heading levels rather than as different style options. It's best practice to start headings at h1 and then move to h2 then h3 and so on as you need to nest sections. If all headers are at the top level, then all header tags should be h1. CSS should be used to resize and change the style as needed.

You can read more about heading tag best practices here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#usage_notes

kendallatada · 2022-12-14T22:11:58Z

pages/illustration.html

+    </nav>
+    <main class="main-section">
+      <!-- page content -->
+      <section class="illustration-contents">


I would recommend only using the <main> tag here since there is only one <section> inside <main>.

kendallatada · 2022-12-14T22:12:46Z

styles/about.css

+.profile-contents {
+  padding: 7%;
+  display: grid;
+  grid-template: auto / 1fr 2fr;


kendallatada · 2022-12-14T22:12:57Z

styles/about.css

+  margin-right: 20px;
+  grid-column: 1 / 2;
+  align-content: center;
+  box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 0.19);


kendallatada · 2022-12-14T22:13:41Z

styles/illustration.css

+}
+
+.flex-items {
+    display: flex;


kendallatada · 2022-12-14T22:15:02Z

pages/index.html

+        <h1 class="general-header">
+          June Valentino
+        </h1>
+        <p class="sub-header">


I'd recommend using an <h2> tag here since this is meant to be a header.

kendallatada · 2022-12-14T22:23:05Z

styles/style.css

+
+.general-description {
+  color: var(--paragraph-t);
+  text-overflow: hidden;


Heads up that hidden isn't a valid value for the text-overflow property.

junemv added 8 commits November 20, 2022 22:04

made lots of layout changes

2e5d546

finished layout for all four pages

def5b7f

finished layout and navigation - created a template for the about page

9b6a0af

added hooks for project buttons to software page, updated UI buttons

2ed1bd7

software page completed - added hooks for image modals in gallery

a1ccc11

updated about me section

50f2409

finished all pages pending validation

35fedf8

passed validation

1eb5454

kendallatada reviewed Dec 14, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cheetahs - June V #100

Cheetahs - June V #100

junemv commented Nov 23, 2022 •

edited

Loading

kendallatada left a comment

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

kendallatada Dec 14, 2022

Cheetahs - June V #100

Are you sure you want to change the base?

Cheetahs - June V #100

Conversation

junemv commented Nov 23, 2022 • edited Loading

Personal Portfolio Site

Comprehension Questions

kendallatada left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junemv commented Nov 23, 2022 •

edited

Loading