Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lions C18 - Nina-Tuyen Tran #109

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

epigmeniocruz
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?

Yes, I had a lot of issues with how I inserted images into my list on my About page. It really didn't like that I coded the images as list items. What I needed to do was wrap the img within a list item which became cumbersome until I realized that I could code the text that accompanied my images as a separate tag (p) to manipulate the formatting separate to the images.

Why is it important to consider and use semantic HTML? |
It makes coding a lot more clear when you need to manipulate specific elements/objects, especially as you add more and more webpages. I found that I ran into the challenge of editing an element using a shared tag across another webpage which meant that when I was making changes to make that element look a certain way, it would change the other shared element if I wasn't being careful and separating tags.

How did you decide to structure your CSS? |
I just kept it simple with a single styles.css file. I used a grid on my About page and a flexbox on my Portfolio page which were then coded separately on my CSS file.

What was the most challenging piece of this assignment? |
Coding the spatial stuff for the grid and flexbox containers. I had to do a lot of editing, refreshing, and trial and error to figure out how to make the changes I wanted to see spatially. On top of that, HTML and CSS is different from Python because when you 'run' (e.g. run open index.html in CLI) to see your webpage, it doesn't give you an error at a specific line of code that is failing from a syntax error, for example, which makes it a lot harder to debut. I didn't run the W3c validator until towards the end as I was finishing, but I wished I had run it a lot sooner because it seems like a very helpful tool similar to Python's built-in debugging.

Describe one area that you gained more clarity on when completing this assignment |
I gained a lot more clarity on what HTML is vs. CSS. From the Learn, I was doing a lot of copying and pasting and still struggling to know when we code in one or the other, but now I understand that HTML is the literal material/content whereas CSS is how it's presented.

Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? | No

Copy link

@nancy-harris nancy-harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage
Answered comprehension questions
Page fully loads
No broken links (regular or images)
Includes at least 3 pages and styling
HTML
Uses the high-level tags for organization: header, footer, main 😞 No use of header or main
Appropriately using semantic tags: section, article, etc. 😞 No use of section or article
All images include alternate text
CSS
Using class and ID names in style declarations 😞 Uses class, but not ID
Style declarations are DRY
Uses Flexbox and/or Grid
Overall

pages/about.html Outdated
@@ -4,9 +4,58 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link href="styles/index.css" rel="stylesheet"/>
<title>Document</title>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the title for each page! This is the text that shows up in the tab in the browser.

Comment on lines -9 to -11
<body>

</body>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, all of the HTML for the body of a webpage should be in the body element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants