B/sky/master (Lauren_Sky) - MediaRanker Waves Completed #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took alot of time to figure out how to do controller testing this weekend since we didn't get much practice time in class where we could ask questions after the lecture on Friday. That being said, I did my best googling to figure it out but would appreciate feedback as I'm still a bit unsure about it. As far as using foundation grids, on the body of the pages I had no problem, but for some reason I just could not figure out how to apply it to the header correctly.
I realize there was alot of duplicated code between each controller, is there a better way to dry this up? ( realized some things like top3 could be moved to the model)
Also, did I deal with render: back properly in my testing?
Heroku deployment: https://cryptic-reef-68640.herokuapp.com/welcome/index