Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sarah Nahmias Media Ranker #75

Open
wants to merge 73 commits into
base: b/sen/master
Choose a base branch
from

Conversation

nahmisa
Copy link

@nahmisa nahmisa commented Oct 17, 2016

On the real live internet! https://young-wildwood-17663.herokuapp.com/

Things I struggled with:
Where to put helper methods - in the model vs. in the view helpers. I do think this project helped me get a better handle on this, but it's still something I don't get intuitively. The code is easier for me to write if things are kept in the view ...

Another thing I struggled with was test. This test in particular was tricky:

test "Upvoting a book adds 1 to its upvotes" do
assert_difference("Book.find(@book.id).upvotes", 1) do
patch :upvote, { id: @book.id }
end
end

I would have liked it to look like this:
test "Upvoting a book adds 1 to its upvotes" do
assert_difference("@book.upvotes", 1) do
patch :upvote, { id: @book.id }
end
end

But that didn't work and I don't understand why and I would like to.

More practice with Foundation I'm sure is in order! I do see how it makes the CSS we write cleaner and more manageable.

I am proud of:
Deploying my site, because that's still quite a few steps with things to go wrong and lots of scary output, so hooray for pushing through that and reading the terminal output and googling stuff. I did not seed my database in production because I didn't want to deal with that (sorry). I am also proud of the tests I wrote for the controllers - especially the index actions. The ordering stuff is pretty slick.

Uses helper methods to make partials work across media
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants