Suzannah Kirk-Daligcon #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e index view--and verified that these routes are working.
… added links that look like buttons to direct to the index pages for movies, books and albums. Roughly styled these links in CSS.
…he upvote functionality so it works
…dating the routes, controller and model
…dating the routes, controller and model
…n the controller along with creating the new view so that adding a new album functions
…or functionality. Also added destroy method to the controller and updated the delete link/button on the show view. THIS COMPLETES ALL BASIC FUNCTIONALITY FOR ALBUMS. NEXT WILL COPY THIS FORMAT TO BOOKS AND MOVIES. THEN WILL FIGURE OUT HOW TO ONLY SHOW THE TOP 5 RANKING ITEMS FROM EACH CATEGORY ON THE HOME PAGE. TEST AND DO STYLING.
… FORMAT TO MOVIES. THEN WILL FIGURE OUT HOW TO ONLY SHOW THE TOP 5 RANKING ITEMS FROM EACH CATEGORY ON THE HOME PAGE. TEST AND DO STYLING.
…UT HOW TO ONLY SHOW THE TOP 5 RANKING ITEMS FROM EACH CATEGORY ON THE HOME PAGE. TEST AND DO STYLING.
…RY ON THE HOME PAGE. Tomorrow will be dedicated to writing tests and styling.
…s all model databases. Then also updated all code to say votes instead of rank in the controllers, models and views. Confirmed migration worked; schema file updated correctly.
… next. And copy across other two models.
… movie object. Schema updated when migration was run.
…onger involved in setting the votes value. Also added :votes validations in the model so that all of the model tests now pass
…nger involved in setting the votes value. Also added :votes validations in the model so that all of the model tests now pass
…onger involved in setting the votes value. Also added :votes validations in the model so that all of the model tests now pass
…ata cell contents
… I tried multiple ways, could not get foundation syntax to work given all of the table pieces I'd already built into this view.
…k, see comments in the file
…ow and edit methods in the album controller.
…w and edit methods in the book controller.
…ow and edit methods in the movie controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sck-media-ranker.herokuapp.com/
yipes! I followed the deployment instructions, and this site isn't yet working...
As far as the project is concerned, I am satisfied with my Wave 1 requirements.
Wave 2 requirements: model tests are strong; controller tests are a solid start.
Wave 3 requirements: I wanted to make my home index page responsive (mirroring the template website). I was able to load Foundation into my app, it altered some of the CSS in ways that I think are improvements. However, was unable to make the home index page responsive--I think due to the fact that I have a lot of table "pieces" in this view. I tried 2-3 different ways of labeling row and column classes with the other Foundation syntax, I couldn't get the view to behave in the way I desired, so I am "tabling" (lol, pun) my responsive exploration until the next project.
One minor piece I'd like to figure out and haven't yet... how to raise an error in my "upvote" methods in all three controllers if .upvote_one returns false.