forked from AdaGold/media-ranker
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M. Johnson MediaRanker B/mbj/master #83
Open
mjohnson3038
wants to merge
22
commits into
Ada-C6:b/mbj/master
Choose a base branch
from
mjohnson3038:b/mbj/master
base: b/mbj/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this has been by far the hardest project for me by far. There were a lot of things that I spent a LONG time working through and still had no success. My biggest challenges were working with the controller test for rank/vote. I left some of my thoughts in as comments, but for some reason, it would not go through and work. I also struggled with the other tests because I think I didn't fully understand how to use the fixture and its relationship with the test database. May we please talk about this some more. I spent too much time working on the controller tests and I still feel that there are many things I wasn't able to consider within them. Although I created the CSS Framework early on, I saved the CSS styling for last and didn't realize how different this would be from regular CSS styling. I was able to make some changes for the files in the application.css but for some reason, it would not allow me to put customized css. For example, I tried to add a class = "button" and then I was going to style all the buttons, but for some reason this was not working. This was in a section were there was also another class, but as far as I could tell, this should not have impacted it. I ultimately did not budget enough time for these final touch ups after spending too much time trying to work through the controller tests. I think it might be helpful to go over the successful completed project to help see examples of things I struggled with.