Dianne MediaRanker #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…movie model objects
…king on logic for redirecting to the current page in show
…inor edits in books controller
…shows the first ten objects
…in the show views, thinking about turning the show views entirely into a partial
…for table display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all pages and mimicked all links and buttons to the best of my ability.
I added a few tests to both models and controllers, but I know more tests are needed in the controllers.
I struggled with moving my "upvote" method into the model.
I now understand partials a lot more, and am seeing where I could use them more often to clean up the code.
Fun times!